Optimize for timer timeout extension #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissl
force-pushed
the
perf/timer_extend
branch
from
a500499
to
ff0a0de
Compare
|
@cmeissl The CI issues are fixed on master, please rebase |
cmeissl
force-pushed
the
perf/timer_extend
branch
from
d04c127
to
44b25e1
Compare
|
@cmeissl try again |
cmeissl
force-pushed
the
perf/timer_extend
branch
2 times, most recently
from
a733023
to
a21bc53
Compare
The CI failed because the version (latest) of |
cmeissl
force-pushed
the
perf/timer_extend
branch
2 times, most recently
from
bbee61f
to
f7ed219
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 85.63% 85.92% +0.28%
==========================================
Files 13 14 +1
Lines 1852 1989 +137
==========================================
+ Hits 1586 1709 +123
- Misses 266 280 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
add benchmarks specifically targeting the use-case of extending a timer by removing and re-registering
in case we constantly extend the same timer the head might already point to the timer we want to cancel. in this case we can directly remove the timer to reduce building up the heap unnecessarily.
it is more likely an older timeout gets canceled and replaced. reversing the search might yield some performance improvement in this case
cmeissl
force-pushed
the
perf/timer_extend
branch
from
f7ed219
to
24a4544
Compare
|
@notgull I had to downgrade a few other deps, but the CI is now green finally! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.